[17.09] Fix the PJA type issue when mapping renames over nested lists. #5414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsoranzo
reviewed
Jan 30, 2018
lib/galaxy/jobs/actions/post.py
Outdated
| # Either a HDCA or a DCE - only HDCA has a name. | ||
| has_collection = input_assoc.dataset_collection | ||
| if hasattr(has_collection, "name"): | ||
| replacement = has_collection.name |
There was a problem hiding this comment.
I'd write it as:
if input_assoc.name == input_file_var:
# Either a HDCA or a DCE - only HDCA has a name.
has_collection = input_assoc.dataset_collection
if has_collection and hasattr(has_collection, "name"):
replacement = has_collection.nameThere was a problem hiding this comment.
Yes - a lot better - I missed the context here thanks!
jmchilton
force-pushed
the
skip_invalid_pja
branch
from
65c15ca
to
9fcac13
Compare
nsoranzo
added
kind/bug
area/workflows
status/review
area/dataset-collections
and removed
triage
labels
nsoranzo
approved these changes
Jan 30, 2018
|
Thanks @jmchilton ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.